Re: [PATCH v2 02/18] vfio: selftests: Split run.sh into separate scripts

[David Matlack]

On Mon, Nov 17, 2025 at 11:58 AM Alex Mastro <amastro@xxxxxx> wrote:
>
> On Wed, Nov 12, 2025 at 07:22:16PM +0000, David Matlack wrote:
> > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> > index 155b5ecca6a9..e9e5c6dc63b6 100644
> > --- a/tools/testing/selftests/vfio/Makefile
> > +++ b/tools/testing/selftests/vfio/Makefile
> > @@ -3,7 +3,11 @@ TEST_GEN_PROGS += vfio_dma_mapping_test
> >  TEST_GEN_PROGS += vfio_iommufd_setup_test
> >  TEST_GEN_PROGS += vfio_pci_device_test
> >  TEST_GEN_PROGS += vfio_pci_driver_test
> > +
> > +TEST_PROGS_EXTENDED := scripts/cleanup.sh
> > +TEST_PROGS_EXTENDED := scripts/lib.sh
> >  TEST_PROGS_EXTENDED := scripts/run.sh
> > +TEST_PROGS_EXTENDED := scripts/setup.sh
>
> I think these assignments will discard prior assignments. Was += intended?

Yes, thanks for catching that!