Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests

[Bart Van Assche]

On 11/15/25 7:52 PM, Yu Kuai wrote:
> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf)
> +{
> +	return op_is_sync(opf) && !op_is_write(opf);
> +}

The name of this function suggests that it performs an action while it
only performs a test. Please consider renaming this function into e.g.
blk_mq_is_sync_read(). I think the suggested name reflects much more
clearly what this function does than "blk_mq_sched_sync_request()".

Thanks,

Bart.