Re: [PATCH] crypto: padlock-sha - Disable broken driver

[Herbert Xu]

On Sun, Nov 16, 2025 at 10:39:26AM -0800, Eric Biggers wrote:
> This driver is known broken, as it computes the wrong SHA-1 and SHA-256
> hashes.  Correctness needs to be the first priority for cryptographic
> code.  Just disable it, allowing the standard (and actually correct)
> SHA-1 and SHA-256 implementations to take priority.

...
 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index a6688d54984c..16ea3e741350 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -38,11 +38,11 @@ config CRYPTO_DEV_PADLOCK_AES
>  	  If unsure say M. The compiled module will be
>  	  called padlock-aes.
>  
>  config CRYPTO_DEV_PADLOCK_SHA
>  	tristate "PadLock driver for SHA1 and SHA256 algorithms"
> -	depends on CRYPTO_DEV_PADLOCK
> +	depends on CRYPTO_DEV_PADLOCK && BROKEN

It's only broken on ZHAOXIN, so this should be conditional on
CPU_SUP_ZHAOXIN.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt