Re: [PATCH v2] block/mq-deadline: Remove redundant hctx pointer dereferencing operation

From: Christoph Hellwig
Date: Tue Nov 18 2025 - 01:09:23 EST


On Tue, Nov 18, 2025 at 09:25:39AM +0800, chengkaitao wrote:
> From: Chengkaitao <chengkaitao@xxxxxxxxxx>
>
> The value of 'hctx->queue' is already stored in '*q' within
> dd_insert_requests, we can directly reuse the result instead of
> dereferencing hctx again in the dd_insert_request function. This
> patch removes the redundant operation and modifies the function's
> parameters accordingly. We can eliminate an LDR instruction.

But you pass additional parameters on the stack. Aka you're causing
churn here with bogus arguments.