Re: [PATCH] staging: iio: adt7316: replace sprintf() with sysfs_emit()

[Nuno Sá]

On Sun, 2025-11-16 at 15:28 +0000, Jonathan Cameron wrote:
> On Sun, 16 Nov 2025 13:08:07 +0200
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> 
> > On Sun, Nov 16, 2025 at 12:16 PM Shi Hao <i.shihao.999@xxxxxxxxx> wrote:
> > > 
> > > Convert several sprintf() calls to sysfs_emit() in the
> > > sysfs show functions, as it is the preferred helper and
> > > prevents potential buffer overruns.
> > > 
> > > No functional changes intended.  
> > 
> > I briefly looked at it and see no issues,
> > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> > 
> 
> Applied, but I will note that this driver is a long way from suitable
> for moving out of staging and I would be surprised if more than
> one or two of the lines changed in this patch make it through the
> necessary refactors (should anyone actually have another go at
> doing them).  Anyhow, I still think this is worth taking just to
> reduce the noise of remaining instances of this.
> 
> I'd have deleted this long ago except I actually have one somewhere
> and it one of the supported parts was still listed as suitable for
> new designs when I checked not long ago.

Seems to be now "just" in production. So no longer advised for new designs. I gave a
quick look and this is far from being a simple driver. It would require a fair amount
of work to bring it out of staging. So, are there users relying on staging drivers?
But I would assume that for staging we are still free to drop support it?

> 
> ADI folk, I would like to hear if we should just delete this one.

I guess Michael is the best person to answer this question.

- Nuno Sá