Re: [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions

From: Peter Zijlstra
Date: Tue Nov 18 2025 - 03:47:35 EST


On Mon, Nov 17, 2025 at 10:31:32AM +0100, Jiri Olsa wrote:
> hi,
> regs argument is not used in several insn-eval functions, removing it.
>
> I have some changes based on these functions and it feels wrong to pass
> NULL in regs argument. Also I don't want to send 5 extra patches with
> my other change, so sending this separately.
>
> thanks,
> jirka
>
>
> ---
> Jiri Olsa (5):
> x86/insn-eval: Remove regs arg from pt_regs_offset
> x86/insn-eval: Remove regs arg from get_reg_offset
> x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off
> x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off
> x86/insn-eval: Remove regs arg from get_reg_offset_16
>
> arch/x86/coco/sev/vc-handle.c | 2 +-
> arch/x86/include/asm/insn-eval.h | 6 +++---
> arch/x86/kernel/cfi.c | 2 +-
> arch/x86/kernel/umip.c | 2 +-
> arch/x86/lib/insn-eval.c | 35 +++++++++++++++--------------------
> arch/x86/mm/extable.c | 2 +-
> 6 files changed, 22 insertions(+), 27 deletions(-)

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>