Re: [PATCH v5 10/34] arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate

From: Ben Horgan
Date: Tue Nov 18 2025 - 05:44:40 EST


Hi Markus,

On 11/17/25 19:50, Markus Elfring wrote:
>
>> +++ b/drivers/resctrl/mpam_devices.c
>> @@ -0,0 +1,190 @@
>
>> +static int mpam_msc_drv_probe(struct platform_device *pdev)
>> +{
>
>> + mutex_lock(&mpam_list_lock);
>> + msc = do_mpam_msc_drv_probe(pdev);
>> + mutex_unlock(&mpam_list_lock);
>
>
> Does anything hinder you to integrate statements like “guard(mutex)(&mpam_list_lock);” here?
> https://elixir.bootlin.com/linux/v6.18-rc6/source/include/linux/mutex.h#L228

The mpam_list_lock needs to be dropped before the end of the scope as it
is also taken in mpam_msc_drv_remove().

>
> Regards,
> Markus

Thanks,

Ben