Re: [PATCH 01/10] soc: qcom: aoss: Use __cleanup() for device_node pointers
From: Dmitry Baryshkov
Date: Tue Nov 18 2025 - 07:26:23 EST
On Tue, Nov 18, 2025 at 12:39:51PM +0100, Krzysztof Kozlowski wrote:
> On 17/11/2025 12:35, Konrad Dybcio wrote:
> > On 11/17/25 5:51 AM, Kathiravan Thirumoorthy wrote:
> >> Make use of the __cleanup() attribute for device_node pointers to simplify
> >> resource management and remove explicit of_node_put() calls.
> >>
> >> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> >> ---
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> This is obviously wrong and not helpful patch.
Describing why it is wrong would be helpful (or having a pointer to an
explanation). Bear in mind people who read email archives and find this
very brief note.
--
With best wishes
Dmitry