Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions

[cp0613]

On Sun, 16 Nov 2025 10:22:34 -0700, pjw@xxxxxxxxxx:

> > The file tools/arch/riscv/include/asm/csr.h borrows from
> > arch/riscv/include/asm/csr.h, and subsequent modifications
> > related to CSR should maintain consistency.
> 
> Thanks for the patch.  A few comments:
> 
> > Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests")
> > Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name")
> 
> It seems like this is pushing the definition of "fixes" here.  It looks 
> like the only thing wrong with those patches is that they didn't change 
> the files under tools/. right?  It would have been nice if they had 
> included the changes to files under tools/, but since the patches don't 
> introduce any bugs directly, I don't think we should include these Fixes: 
> lines here.
> 

Yes, that's true, thanks for reminding me.

> >
> > Signed-off-by: Chen Pei <cp0613@xxxxxxxxxxxxxxxxx>
> 
> Please, no blank line between the Fixes: headers and the Signed-off-by:.
> 
> I've removed the Fixes: lines and the superfluous blank line, and queued 
> this for v6.18-rc fixes.
> 

Thank you for your help.

> 
> - Paul

Thanks,
Pei