Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

[Krzysztof Kozlowski]

On 18/11/2025 16:56, Michael Opdenacker wrote:
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
> 
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxx>
> 
> ---
> 
> Changes in V3:
> 
> - Remove this Acked-by as the binding code changed substantially:
>   Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Above commit msg and DTS suggests they are pretty compatible with each
other, so I don't quite get why this changed. Your changelog says
"unexpectedly turns out to be compatible with 3 but not 3S.", but is
this real or are you just guessing? I think you were tricked to change
correct code into this.

Anyway, however odd this is, I don't care enough to stop this patchset, so:

Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>


Best regards,
Krzysztof