RE: [PATCH v2] mm/hugetlb: Fix incorrect error return from hugetlb_reserve_pages()

From: Shameer Kolothum

Date: Sun Nov 23 2025 - 14:40:37 EST


A gentle ping...It would be great if this can be picked up if there
are no further comments.

Thanks,
Shameer

> -----Original Message-----
> From: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
> Sent: 24 October 2025 15:51
> To: Shameer Kolothum <skolothumtho@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> muchun.song@xxxxxxxxx; osalvador@xxxxxxx; vivek.kasireddy@xxxxxxxxx;
> joshua.hahnjy@xxxxxxxxx; Jason Gunthorpe <jgg@xxxxxxxxxx>; Nicolin
> Chen <nicolinc@xxxxxxxxxx>; Nathan Chen <nathanc@xxxxxxxxxx>; Matt
> Ochs <mochs@xxxxxxxxxx>
> Subject: Re: [PATCH v2] mm/hugetlb: Fix incorrect error return from
> hugetlb_reserve_pages()


> Reviewed-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
>
> [...snip...]
>
> > + /* region_chg() above can return -ENOMEM */
> > + err = (chg == -ENOMEM) ? -ENOMEM : -EINVAL;
>
> And this looks much more elegant than the version I wrote : -)