Re: [PATCH] platform/x86: asus-armoury: fix only DC tunables being available

From: Denis Benato

Date: Sun Nov 23 2025 - 10:22:01 EST



On 11/23/25 16:05, Denis Benato wrote:
> Module asus-armoury must use AC tunables to check availability
No idea why I missed the double space here.

Do I resend a corrected version? Should checkpatch.pl also check for this?
> of power-related firmware attributes: fix missing attributes
> by using AC attributes instead of DC.
>
> Signed-off-by: Denis Benato <denis.benato@xxxxxxxxx>
> ---
> drivers/platform/x86/asus-armoury.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5106e8a41e25..9c1a9ad42bc4 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -869,7 +869,8 @@ static bool has_valid_limit(const char *name, const struct power_limits *limits)
>
> static int asus_fw_attr_add(void)
> {
> - const struct rog_tunables *const ac_rog_tunables = asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_DC];
> + const struct rog_tunables *const ac_rog_tunables =
> + asus_armoury.rog_tunables[ASUS_ROG_TUNABLE_AC];
> const struct power_limits *limits;
> bool should_create;
> const char *name;