Re: [PATCH] net: dsa: Fix error handling in dsa_port_parse_of

[Markus Elfring]

…
> returned structure, which should be balanced with a corresponding
> put_device() when the reference is no longer needed.
…

* Would a corresponding imperative wording become helpful for an improved change description?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc6#n94

* How do you think about to omit an extra check for the variable “err”
  in the affected if branch because it can always be returned here?

* Would it be helpful to append parentheses to the function name in the summary phrase?


Regards,
Markus