Re: [PATCH v4 1/2] dt-bindings: iio: amplifiers: add adl8113

[David Lechner]

On 11/21/25 3:52 AM, Antoniu Miclaus wrote:
> Add devicetree bindings for adl8113.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---
> 

...

> +  adi,external-bypass-a-gain-db:

Hmm... are we sure we will never need a non-integer value? Maybe we should add
"-microdb$" to dtschema?

https://github.com/devicetree-org/dt-schema/blob/7033eb7cec1abe55f496309f0f6f271524f5d612/dtschema/schemas/property-units.yaml#L52

> +    description:
> +      Gain in dB of external amplifier connected to bypass path A (OUT_A/IN_A).
> +      When specified, this gain value becomes selectable via the hardwaregain
> +      attribute and automatically routes through the external A path.

The dt-bindings should not specify how the driver should operate. We can
leave out the last sentence. We could say though that when omitted it
means nothing is connected.