RE: [PATCH v3 02/13] serial: rsci: Drop rsci_clear_CFC()

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 21 November 2025 14:53
> Subject: Re: [PATCH v3 02/13] serial: rsci: Drop rsci_clear_CFC()
> 
> Hi Biju,
> 
> On Fri, 14 Nov 2025 at 11:52, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Drop rsci_clear_CFC() by reusing rsci_clear_SCxSR() as the contents of
> > both functions are the same.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/drivers/tty/serial/rsci.c
> > +++ b/drivers/tty/serial/rsci.c
> > @@ -199,11 +199,6 @@ static unsigned int rsci_get_mctrl(struct uart_port *port)
> >         return 0;
> >  }
> >
> > -static void rsci_clear_CFC(struct uart_port *port, unsigned int mask)
> > -{
> > -       rsci_serial_out(port, CFCLR, mask);
> > -}
> > -
> 
> This function is indeed identical to rsci_clear_SCxSR(), so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> However, while the sci_port_ops method is indeed called .clear_SCxSR(), I think it makes more sense to
> drop rsci_clear_SCxSR() instead, as this function touches the CFC register...

OK, will change this in next version.

Cheers,
Biju