Re: [PATCH v2 0/6] ALSA: ctxfi: Add support for Onkyo SE-300PCIE

[Harin Lee]

I noticed that 'rca_state' in patch 5 uses 'unsigned char'. While it is
safe due to the bounds check, I plan to switch it to 'unsigned int' for
strict correctness.

I also have two questions regarding conventions:

1. ALSA control name (on patch 5): Is "Dedicated Output Playback Enum"
acceptable, or would you prefer a simpler name?
2. CA20K2 port logic (on patch 6): The condition
'if ((idx < 4) && ((hw->model != CTOK0010) || (idx < 3)))' handles
the non-standard RCA port mapping. Does this line require additional
comments or a helper function for better readability?

Please let me know if you would prefer me to send a v3.

On 11/22/25 12:22 AM, Harin Lee wrote:
> I added support for the Onkyo SE-300PCIE (OK0010), a Creative X-Fi
> CA20K2-based sound card with dual TI PCM1798 DACs, a single TI PCM1681
> DAC for 7.1ch output, and a CS5364 ADC. This model differs
> significantly from other CA20K2-based variants.
>
> Since official driver support for this hardware was discontinued a long
> time ago, this patch series enables the card to be used on modern
> platforms.
>
> This patch series was developed using QEMU vfio tracing, and PCIe BAR
> dumps. Tested with analog output (up to 192kHz) and line/microphone
> input (up to 96kHz) at various sample rates.
>
> Changes in v2:
>   - Fix coding style issue (mixed declaration and code) in
>     dedicated_rca_put().
>
> Harin Lee (6):
>    ALSA: ctxfi: Add hw parameter to daio_mgr_dao_init()
>    ALSA: ctxfi: Add ADC helper functions for GPIO
>    ALSA: ctxfi: Use explicit output flag for DAIO resources
>    ALSA: ctxfi: Refactor resource alloc for sparse mappings
>    ALSA: ctxfi: Add support for dedicated RCA switching
>    ALSA: ctxfi: Add support for Onkyo SE-300PCIE (OK0010)
>
>   sound/pci/ctxfi/ctatc.c      | 97 ++++++++++++++++++++++++++----------
>   sound/pci/ctxfi/ctatc.h      |  8 +--
>   sound/pci/ctxfi/ctdaio.c     | 18 ++++---
>   sound/pci/ctxfi/ctdaio.h     |  3 ++
>   sound/pci/ctxfi/cthardware.h |  4 +-
>   sound/pci/ctxfi/cthw20k1.c   |  3 +-
>   sound/pci/ctxfi/cthw20k2.c   | 79 ++++++++++++++++++++++-------
>   sound/pci/ctxfi/ctmixer.c    | 73 +++++++++++++++++++++++++--
>   8 files changed, 223 insertions(+), 62 deletions(-)