Re: [PATCH] crypto: starfive: Correctly handle return of sg_nents_for_len

From: Herbert Xu

Date: Fri Nov 21 2025 - 22:14:07 EST


On Mon, Nov 10, 2025 at 02:54:38PM +0800, Haotian Zhang wrote:
> The return value of sg_nents_for_len was assigned to an unsigned long
> in starfive_hash_digest, causing negative error codes to be converted
> to large positive integers.
>
> Add error checking for sg_nents_for_len and return immediately on
> failure to prevent potential buffer overflows.
>
> Fixes: 7883d1b28a2b ("crypto: starfive - Add hash and HMAC support")
> Signed-off-by: Haotian Zhang <vulab@xxxxxxxxxxx>
> ---
> drivers/crypto/starfive/jh7110-hash.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt