Re: [PATCH v5 0/7] Add AMD ISP4 driver

[Mario Limonciello]

> > > I'm at a loss on how I can retrieve some debug info for this issue. :/
> >
> > You are on the latest BIOS presumably, right?
> >
> > If you schedule a suspend with amd-s2idle for ~10 seconds, does it reproduce
> > too?
>
> Oh my God, I ran `amd-s2idle test` and got this:
>
>    ❌ IOMMU is misconfigured: missing MSFT0201 ACPI device
>    [...]
>    🚫 Your system does not meet s2idle prerequisites!
>    🗣 Explanations for your system
>    🚦 Device MSFT0201 missing from ACPI tables
>    The ACPI device MSFT0201 is required for suspend to work when the IOMMU is enabled. Please check your BIOS settings and if configured correctly, report a bug to your system vendor.
>    For more information on this failure see:https://gitlab.freedesktop.org/drm/amd/-/issues/3738#note_2667140
>
> So then I reenabled Pluton in the BIOS and waking from suspend works now!!!
>
> This had slipped past my test with BIOS settings reset to factory defaults
> because the BIOS has a separate button to reset *security settings* to factory
> defaults. And Pluton is one of those security settings.
>
> When I had Pluton disabled, it always took at least 60 seconds to enter S0i3,
> measured on a stopwatch. Now S0i3 entry takes much less time as you say.
>
> Well, that fixes a bunch of struggles I had with this laptop. :) Thank you!

Well that's great news to hear.  I'm glad that check in amd-s2idle has 
come in handy.

> Also, since I have your attention on S0i3, there is always this warning splat
> printed on resume from S0i3, both with and without IOMMU enabled:

Yes; I'm aware of this, Pratap is looking at how to approach it.  It 
should be functionally harmless at least.

>    [  366.694362] ------------[ cut here ]------------
>    [  366.694367] amdgpu 0000:c3:00.0: SMU uninitialized but power ungate requested for 16!
>    [  366.694427] WARNING: CPU: 12 PID: 3122 at drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:398 smu_dpm_set_power_gate+0x1d7/0x1f0 [amdgpu]
>    [  366.694640] Modules linked in: ccm hid_sensor_gyro_3d hid_sensor_prox hid_sensor_trigger industrialio_triggered_buffer kfifo_buf hid_sensor_iio_common industrialio hid_sensor_hub rfcomm snd_seq_dummy snd_hrtimer snd_seq snd_seq_device amd_capture videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc pinctrl_amdisp i2c_designware_amdisp uhid cmac algif_hash algif_skcipher af_alg bnep uinput nls_iso8859_1 vfat fat snd_acp_legacy_mach joydev snd_acp_mach mousedev intel_rapl_msr snd_soc_nau8821 snd_hda_scodec_cs35l56_spi intel_rapl_common snd_acp3x_rn amdgpu snd_acp70 snd_ctl_led snd_acp_i2s snd_acp_pdm snd_soc_dmic snd_acp_pcm snd_sof_amd_acp70 snd_sof_amd_acp63 snd_sof_amd_vangogh snd_sof_amd_rembrandt snd_hda_codec_alc269 snd_sof_amd_renoir snd_hda_scodec_component snd_sof_amd_acp snd_sof_pci snd_hda_codec_realtek_lib snd_sof_xtensa_dsp snd_hda_codec_generic snd_sof snd_sof_utils snd_pci_ps snd_soc_acpi_amd_match snd_amd_sdw_acpi soundwire_amd soundwire_generic_allocation mt7925e soundwire_bus
>    [  366.694715]  snd_hda_codec_atihdmi mt7925_common snd_soc_sdca snd_hda_codec_hdmi mt792x_lib snd_soc_core mt76_connac_lib snd_compress drm_panel_backlight_quirks amdxcp btusb ac97_bus drm_buddy snd_hda_intel mt76 snd_pcm_dmaengine btrtl drm_exec snd_rpl_pci_acp6x drm_suballoc_helper snd_hda_codec btintel drm_ttm_helper btbcm mac80211 snd_hda_scodec_cs35l56_i2c snd_acp_pci snd_hda_core ttm btmtk ucsi_acpi snd_hda_scodec_cs35l56 snd_amd_acpi_mach libarc4 snd_intel_dspcfg snd_hda_cirrus_scodec i2c_algo_bit typec_ucsi snd_acp_legacy_common spd5118 snd_intel_sdw_acpi bluetooth drm_display_helper snd_soc_cs35l56_shared snd_pci_acp6x snd_hwdep snd_soc_cs_amp_lib typec hp_wmi cfg80211 cs_dsp cec kvm_amd snd_pci_acp5x snd_pcm hid_multitouch ecdh_generic roles sp5100_tco sparse_keymap wmi_bmof amd_pmf kvm snd_timer snd_rn_pci_acp3x i2c_hid_acpi snd_acp_config video amdtee serial_multi_instantiate i2c_hid irqbypass i2c_piix4 snd snd_soc_acpi amdxdna snd_pci_acp3x soundcore amd_sfh platform_profile wmi i2c_smbus rfkill
>    [  366.694807]  wireless_hotkey thunderbolt amd_pmc gpu_sched rapl mac_hid i2c_dev sg crypto_user loop nfnetlink ip_tables x_tables dm_crypt encrypted_keys trusted asn1_encoder tee dm_mod polyval_clmulni ghash_clmulni_intel aesni_intel nvme nvme_core serio_raw nvme_keyring ccp nvme_auth
>    [  366.694840] CPU: 12 UID: 0 PID: 3122 Comm: kworker/u129:47 Tainted: G        W           6.17.7 #1 PREEMPT
>    [  366.694846] Tainted: [W]=WARN
>    [  366.694848] Hardware name: HP HP ZBook Ultra G1a 14 inch Mobile Workstation PC/8D01, BIOS X89 Ver. 01.03.02 06/18/2025
>    [  366.694852] Workqueue: async async_run_entry_fn
>    [  366.694867] RIP: 0010:smu_dpm_set_power_gate+0x1d7/0x1f0 [amdgpu]
>    [  366.694974] Code: 85 ed 75 03 48 8b 2f 89 74 24 04 e8 f3 85 da cb 44 8b 44 24 04 48 89 d9 48 89 ea 48 89 c6 48 c7 c7 48 80 fc c1 e8 c9 0d 63 cb <0f> 0b b8 a1 ff ff ff e9 a1 fe ff ff e9 3b b3 3b 00 e9 36 b3 3b 00
>    [  366.694977] RSP: 0018:ffff8fad27387ce8 EFLAGS: 00010246
>    [  366.694981] RAX: 0000000000000000 RBX: ffffffffc2006846 RCX: 0000000000000027
>    [  366.694984] RDX: ffff8fcbde51abc8 RSI: 0000000000000001 RDI: ffff8fcbde51abc0
>    [  366.694985] RBP: ffff8fad016afc80 R08: 0000000000000000 R09: 00000000ffffdfff
>    [  366.694986] R10: ffffffff8e6d5da0 R11: ffff8fad27387b88 R12: ffff8fad25a80000
>    [  366.694987] R13: ffff8fad25a96680 R14: 0000000000000001 R15: ffffffffc1e7ce80
>    [  366.694989] FS:  0000000000000000(0000) GS:ffff8fcc4fe73000(0000) knlGS:0000000000000000
>    [  366.694990] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>    [  366.694992] CR2: 00007f58f6956408 CR3: 0000000116015000 CR4: 0000000000f50ef0
>    [  366.694993] PKRU: 55555554
>    [  366.694995] Call Trace:
>    [  366.695003]  <TASK>
>    [  366.695007]  amdgpu_dpm_set_powergating_by_smu+0xf1/0x110 [amdgpu]
>    [  366.695136]  _genpd_power_on+0x83/0x120
>    [  366.695149]  genpd_sync_power_on.part.0+0x66/0xc0
>    [  366.695154]  genpd_finish_resume+0x6f/0xd0
>    [  366.695157]  ? genpd_thaw_noirq+0x10/0x10
>    [  366.695159]  dpm_run_callback.isra.0+0x28/0x90
>    [  366.695166]  device_resume_noirq+0xc7/0x210
>    [  366.695169]  async_resume_noirq+0x1c/0x30
>    [  366.695171]  async_run_entry_fn+0x1f/0xa0
>    [  366.695175]  process_one_work+0x173/0x270
>    [  366.695183]  worker_thread+0x2d7/0x410
>    [  366.695188]  ? rescuer_thread+0x4e0/0x4e0
>    [  366.695191]  kthread+0xe6/0x1e0
>    [  366.695196]  ? kthread_queue_delayed_work+0x80/0x80
>    [  366.695199]  ? kthread_queue_delayed_work+0x80/0x80
>    [  366.695202]  ret_from_fork+0xf0/0x110
>    [  366.695211]  ? kthread_queue_delayed_work+0x80/0x80
>    [  366.695214]  ? kthread_queue_delayed_work+0x80/0x80
>    [  366.695217]  ret_from_fork_asm+0x11/0x20
>    [  366.695224]  </TASK>
>    [  366.695225] ---[ end trace 0000000000000000 ]---
>
>
> > > [1] https://www.reddit.com/r/AMDLaptops/comments/1mmrlgz/hp_zbook_ultra_g1a_ubuntu_fully_working_now_or/
> > > [2] https://www.reddit.com/r/AMDLaptops/comments/1mmrlgz/comment/nd4cldp/
> > > [3] https://forum.level1techs.com/t/the-ultimate-arch-secureboot-guide-for-ryzen-ai-max-ft-hp-g1a-128gb-8060s-monster-laptop/230652#hibernate-suspend-and-kernel-versions-16
> > > [4] https://www.reddit.com/r/AMDLaptops/comments/1mmrlgz/comment/nd1xbtd/
> > > [5] https://ftp.hp.com/pub/softpaq/sp158501-159000/stella-noble-oem-24.04b-20250422-107.iso

Maybe share some pointers over to these threads about your findings too!