Re: [PATCH 2/2] gpio: tegra186: Add support for Tegra256

[Jon Hunter]

On 23/08/2025 06:54, Prathamesh Shete wrote:
> Extend the existing Tegra186 GPIO controller driver with support for the
> GPIO controller found on Tegra256. While the programming model remains
> the same, the number of pins has slightly changed.
>
> Signed-off-by: Prathamesh Shete <pshete@xxxxxxxxxx>
> ---
>   drivers/gpio/gpio-tegra186.c | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index d27bfac6c9f5..c9f1441a7b30 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -20,6 +20,7 @@
>   #include <dt-bindings/gpio/tegra194-gpio.h>
>   #include <dt-bindings/gpio/tegra234-gpio.h>
>   #include <dt-bindings/gpio/tegra241-gpio.h>
> +#include <dt-bindings/gpio/tegra256-gpio.h>
>   
>   /* security registers */
>   #define TEGRA186_GPIO_CTL_SCR 0x0c
> @@ -1274,6 +1275,30 @@ static const struct tegra_gpio_soc tegra241_aon_soc = {
>   	.has_vm_support = false,
>   };
>   
> +#define TEGRA256_MAIN_GPIO_PORT(_name, _bank, _port, _pins)	\
> +	[TEGRA256_MAIN_GPIO_PORT_##_name] = {			\
> +		.name = #_name,					\
> +		.bank = _bank,					\
> +		.port = _port,					\
> +		.pins = _pins,					\
> +	}
> +
> +static const struct tegra_gpio_port tegra256_main_ports[] = {
> +	TEGRA256_MAIN_GPIO_PORT(A, 0, 0, 8),
> +	TEGRA256_MAIN_GPIO_PORT(B, 0, 1, 8),
> +	TEGRA256_MAIN_GPIO_PORT(C, 0, 2, 8),
> +	TEGRA256_MAIN_GPIO_PORT(D, 0, 3, 8),
> +};
> +
> +static const struct tegra_gpio_soc tegra256_main_soc = {
> +	.num_ports = ARRAY_SIZE(tegra256_main_ports),
> +	.ports = tegra256_main_ports,
> +	.name = "tegra256-gpio-main",
> +	.instance = 1,

Shouldn't this be 0?

Jon

--
nvpublic