Re: "controller is down; will reset" on SK Hynix NVMe drive in Lenovo IdeaPad Pro 5

[Thomas ten Cate]

On Thu, Nov 20, 2025 at 10:04 PM Keith Busch <kbusch@xxxxxxxxxx> wrote:
>
> I assume vendor 0x1c5c for SK Hynix,

Correct.

> but we also need the device id to
> make a quirk. You can get that info from sysfs, for example if your
> device is enumerated as "nvme0":
>
>   # cat /sys/class/nvme/nvme0/device/device

0x1d59

> There's two quirks we can try: NVME_QUIRK_NO_DEEPEST_PS first, then
> NVME_QUIRK_NO_APST if the first one wasn't successful.

I tried adding the following to linux/drivers/nvme/host/core.c, in the
core_quirks[] array. It takes a model name, not a device id, which I
took from /sys/class/nvme/nvme0/model.

{
  .vid = 0x1c5c,
  .mn = "SKHynix_HFS001TEJ4X112N",
  .quirks = NVME_QUIRK_NO_APST,
}

With NVME_QUIRK_NO_DEEPEST_PS, it still hung almost immediately. With
NVME_QUIRK_NO_APST, it appears to be stable.

Would you like me to send a patch?