Re: [PATCH v2 1/4] dt-bindings: vendor-prefixes: Add prefix for XuanTie

[Conor Dooley]

On Fri, Nov 21, 2025 at 10:01:07AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 21, 2025 at 02:34:36PM +0800, cp0613@xxxxxxxxxxxxxxxxx wrote:
> > From: Chen Pei <cp0613@xxxxxxxxxxxxxxxxx>
> > 
> > Add new vendor strings to dt bindings for RISC-V vendor XuanTie.
> > 
> > Signed-off-by: Chen Pei <cp0613@xxxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index f1d1882009ba..5d28b2da94cd 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -1829,6 +1829,8 @@ patternProperties:
> >      description: Xilinx
> >    "^xnano,.*":
> >      description: Xnano
> > +  "^xuantie,.*":
> > +    description: C-SKY Microsystems Co., Ltd. (XuanTie)
> 
> We do not create new prefixes for existing entries. You have already
> csky, alibaba and thead and probably many more. Choose some appropriate.

When the vendor literally says "C-SKY", it's hard to buy why csky
shouldn't be used here. Xuantie is described as being a brand, where at
least t-head was a company. This seems akin to having
"snapdragon,msm8660" instead of "qcom,msm8660", for example.

> 
> Your commit msg should also explain anything unusual here, like above.
> 
> Best regards,
> Krzysztof
>

Attachment: signature.asc
Description: PGP signature