Re: [PATCH] net/sched: act_ife: convert comma to semicolon
From: Simon Horman
Date: Fri Nov 21 2025 - 06:47:38 EST
On Wed, Nov 12, 2025 at 05:50:36AM -0500, Jamal Hadi Salim wrote:
> On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@xxxxxxxxxxx> wrote:
> >
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
>
> IIRC, Simon brought this up in the review as well...
Yes, I might have.
But at any rate I agree with the analysis above.
>
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
>
> Reviewed-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>
...