Re: [PATCH v5 2/3] arm64: tegra: Add interconnect properties to Tegra210 device-tree

[Jon Hunter]

On 22/10/2025 04:13, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@xxxxxxxxx>
>
> Add interconnect properties to the Memory Controller, External Memory
> Controller and the Display Controller nodes in order to describe hardware
> interconnection.
>
> Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> ---
>   arch/arm64/boot/dts/nvidia/tegra210.dtsi | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210.dtsi b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> index 6da10db893add44a98fde1666c382511212fd43c..2fcc7a28690f7100d49e8b93c4fb77de7947b002 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210.dtsi
> @@ -202,6 +202,19 @@ dc@54200000 {
>   
>   			nvidia,outputs = <&dsia &dsib &sor0 &sor1>;
>   			nvidia,head = <0>;
> +
> +			interconnects = <&mc TEGRA210_MC_DISPLAY0A &emc>,
> +					<&mc TEGRA210_MC_DISPLAY0B &emc>,
> +					<&mc TEGRA210_MC_DISPLAY0C &emc>,
> +					<&mc TEGRA210_MC_DISPLAYHC &emc>,
> +					<&mc TEGRA210_MC_DISPLAYD &emc>,
> +					<&mc TEGRA210_MC_DISPLAYT &emc>;
> +			interconnect-names = "wina",
> +					     "winb",
> +					     "winc",
> +					     "cursor",
> +					     "wind",
> +					     "wint";
>   		};
>   
>   		dc@54240000 {
> @@ -217,6 +230,15 @@ dc@54240000 {
>   
>   			nvidia,outputs = <&dsia &dsib &sor0 &sor1>;
>   			nvidia,head = <1>;
> +
> +			interconnects = <&mc TEGRA210_MC_DISPLAY0AB &emc>,
> +					<&mc TEGRA210_MC_DISPLAY0BB &emc>,
> +					<&mc TEGRA210_MC_DISPLAY0CB &emc>,
> +					<&mc TEGRA210_MC_DISPLAYHCB &emc>;
> +			interconnect-names = "wina",
> +					     "winb",
> +					     "winc",
> +					     "cursor";
>   		};
>   
>   		dsia: dsi@54300000 {
> @@ -990,6 +1012,7 @@ mc: memory-controller@70019000 {
>   
>   		#iommu-cells = <1>;
>   		#reset-cells = <1>;
> +		#interconnect-cells = <1>;
>   	};
>   
>   	emc: external-memory-controller@7001b000 {
> @@ -1001,6 +1024,7 @@ emc: external-memory-controller@7001b000 {
>   		clock-names = "emc";
>   		interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
>   		nvidia,memory-controller = <&mc>;
> +		#interconnect-cells = <0>;
>   		#cooling-cells = <2>;
>   	};


I am seeing another failure on -next for Tegra210 and bisect is point to 
this commit ...

# first bad commit: [3cad4369399a31277e9e20de723c665b30cba574] arm64: 
tegra: Add interconnect properties for Tegra210

The tegra-tests [0] devices test is failing and after this commit the 
DRM device is no longer bound to the driver.

Jon

[0] https://github.com/thierryreding/tegra-tests
--
nvpublic