[PATCH] crypto: hisilicon/qm - fix device leak on QoS updates

From: Johan Hovold

Date: Fri Nov 21 2025 - 06:11:56 EST


Make sure to drop the reference taken when looking up the PCI device on
QoS updates.

Fixes: 22d7a6c39cab ("crypto: hisilicon/qm - add pci bdf number check")
Cc: stable@xxxxxxxxxxxxxxx # 6.2
Cc: Kai Ye <yekai13@xxxxxxxxxx>
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
---
drivers/crypto/hisilicon/qm.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index a5b96adf2d1e..ef6fdcc3dbcb 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -3871,11 +3871,14 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
pdev = container_of(dev, struct pci_dev, dev);
if (pci_physfn(pdev) != qm->pdev) {
pci_err(qm->pdev, "the pdev input does not match the pf!\n");
+ put_device(dev);
return -EINVAL;
}

*fun_index = pdev->devfn;

+ put_device(dev);
+
return 0;
}

--
2.51.2