Re: [PATCH libcrypto v2 1/3] wifi: iwlwifi: trans: rename at_least variable to min_mode

[Ard Biesheuvel]

(cc linux-wireless)

On Thu, 20 Nov 2025 at 02:11, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>
> The subsequent commit is going to add a macro that redefines `at_least`
> to mean something else. Given that the usage here in iwlwifi is the only
> use of that identifier in the whole kernel, just rename it to a more
> fitting name, `min_mode`.
>
> Cc: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

> ---
>  drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-trans.c b/drivers/net/wireless/intel/iwlwifi/iwl-trans.c
> index 5232f66c2d52..cc8a84018f70 100644
> --- a/drivers/net/wireless/intel/iwlwifi/iwl-trans.c
> +++ b/drivers/net/wireless/intel/iwlwifi/iwl-trans.c
> @@ -129,7 +129,7 @@ static enum iwl_reset_mode
>  iwl_trans_determine_restart_mode(struct iwl_trans *trans)
>  {
>         struct iwl_trans_dev_restart_data *data;
> -       enum iwl_reset_mode at_least = 0;
> +       enum iwl_reset_mode min_mode = 0;
>         unsigned int index;
>         static const enum iwl_reset_mode escalation_list_old[] = {
>                 IWL_RESET_MODE_SW_RESET,
> @@ -173,11 +173,11 @@ iwl_trans_determine_restart_mode(struct iwl_trans *trans)
>         }
>
>         if (trans->restart.during_reset)
> -               at_least = IWL_RESET_MODE_REPROBE;
> +               min_mode = IWL_RESET_MODE_REPROBE;
>
>         data = iwl_trans_get_restart_data(trans->dev);
>         if (!data)
> -               return at_least;
> +               return min_mode;
>
>         if (!data->backoff &&
>             ktime_get_boottime_seconds() - data->last_error >=
> @@ -194,7 +194,7 @@ iwl_trans_determine_restart_mode(struct iwl_trans *trans)
>                 data->backoff = false;
>         }
>
> -       return max(at_least, escalation_list[index]);
> +       return max(min_mode, escalation_list[index]);
>  }
>
>  #define IWL_TRANS_TOP_FOLLOWER_WAIT    180 /* ms */
> --
> 2.52.0
>