Re: [PATCH v9 4/6] phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920

[Vinod Koul]

On 21-11-25, 13:36, Pritam Manohar Sutar wrote:
> Hi Vinod,
> 
> > -----Original Message-----
> > From: Vinod Koul <vkoul@xxxxxxxxxx>
> > Sent: 20 November 2025 10:07 PM
> > To: Pritam Manohar Sutar <pritam.sutar@xxxxxxxxxxx>
> > Cc: kishon@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> > conor+dt@xxxxxxxxxx; alim.akhtar@xxxxxxxxxxx; andre.draszik@xxxxxxxxxx;
> > peter.griffin@xxxxxxxxxx; kauschluss@xxxxxxxxxxx; johan@xxxxxxxxxx;
> > ivo.ivanov.ivanov1@xxxxxxxxx; m.szyprowski@xxxxxxxxxxx;
> > s.nawrocki@xxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx;
> > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
> > kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> > rosa.pila@xxxxxxxxxxx; dev.tailor@xxxxxxxxxxx;
> > faraz.ata@xxxxxxxxxxx; muhammed.ali@xxxxxxxxxxx;
> > selvarasu.g@xxxxxxxxxxx
> > Subject: Re: [PATCH v9 4/6] phy: exynos5-usbdrd: support HS combo phy for
> > ExynosAutov920
> > 
> > On 10-10-25, 12:39, Pritam Manohar Sutar wrote:
> > > Support UTMI+ combo phy for this SoC which is somewhat simmilar to
> >                                                         ^^^^^^^^ typo
> > 
> > > what the existing Exynos850 support does. The difference is that some
> > > register offsets and bit fields are defferent from Exynos850.
> >                                            ^^^^^^^^ again
> 
> Thank for the review and sorry for the typo and can you please
> confirm if updated commit message is fine, mentioned as below?
> 
> "
>     phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920
> 
>     Support UTMI+ combo phy for this SoC, which is somewhat similar to
>     what the existing Exynos850 supports. The difference is that some
>     register offsets and bit fields are different from Exynos850.
> 
>     Add required change in phy driver to support combo HS phy for this SoC.
> "

better :-)
-- 
~Vinod