Re: linux-next: Fixes tag needs some work in the ftrace tree

[Tomas Glozar]

pá 21. 11. 2025 v 1:00 odesílatel Stephen Rothwell
<sfr@xxxxxxxxxxxxxxxx> napsal:
>
> Hi all,
>
> In commit
>
>   f45a0cb29720 ("rtla/tests: Fix osnoise test calling timerlat")
>
> Fixes tag
>
>   Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")
>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>
>  ...

Oops! Apparently, I forgot to use checkpatch on the patchset:

$ scripts/checkpatch.pl /tmp/test.patch
WARNING: Please use correct Fixes: style 'Fixes: <12+ chars of sha1>
("<title line>")' - ie: 'Fixes: 05b7e10687c6 ("tools/rtla: Add
remaining support for osnoise actions"
)'
#75:
Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")

>     This can be fixed for the future by setting core.abbrev to 12 (or
>     more) or (for git v2.11 or later) just making sure it is not set
>     (or set to "auto").
>

Ah, good to know! My setup is fine, the issue was that I have not used
git log --oneline, but regular git log, and counted the characters by
myself.

Thank you for catching this.

Tomas