Re: [PATCH] ACPI: GTDT: Correctly number platform devices for MMIO timers

[Marc Zyngier]

On Fri, 21 Nov 2025 02:53:17 +0000,
Hanjun Guo <guohanjun@xxxxxxxxxx> wrote:
> 
> On 2025/10/30 19:01, Marc Zyngier wrote:
> > Use the actual timer counter instead of the watchdog counter.
> > 
> > Fixes: 5669d92f3efa4 ("ACPI: GTDT: Generate platform devices for MMIO timers")
> > Reported-by: Pavan Kondeti <pavan.kondeti@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> > Cc: Hanjun Guo <guohanjun@xxxxxxxxxx>
> > Cc: Sudeep Holla <sudeep.holla@xxxxxxx>
> > Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > ---
> >   drivers/acpi/arm64/gtdt.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index fd995a1d3d248..8cc8af8fd408c 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -430,10 +430,10 @@ static int __init gtdt_platform_timer_init(void)
> >   				continue;
> >     			pdev = platform_device_register_data(NULL,
> > "gtdt-arm-mmio-timer",
> > -							     gwdt_count, &atm,
> > +							     mmio_timer_count, &atm,
> >   							     sizeof(atm));
> >   			if (IS_ERR(pdev)) {
> > -				pr_err("Can't register timer %d\n", gwdt_count);
> > +				pr_err("Can't register timer %d\n", mmio_timer_count);
> >   				continue;
> >   			}
> 
> "typo" I think :)
> 
> Acked-by: Hanjun Guo <guohanjun@xxxxxxxxxx>
> 
> Will this go via ARM64 tree?

Is that where the ACPI updates are routed to? This fixes a patch that
was routed tip, so I'd have expected this to go via the same route.

In any case, I've added Catalin and Will on Cc.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.