Re: [PATCH v6 1/2] dt-bindings: phy: google: Add Google Tensor G5 USB PHY

[Krzysztof Kozlowski]

On Thu, Nov 20, 2025 at 05:36:41PM +0000, Roy Luo wrote:

I read last discussion and patch is fine, except one issue in example I
never noticed before (see at the end), which I want to fix. Apologies
for not bringing it up anytime earlier, I missed it. While at it also
one more nit.

> +description: |

nit: drop |, do not need '|' unless you need to preserve formatting.

> +  Describes the USB PHY interfaces integrated with the DWC3 USB controller on
> +  Google Tensor SoCs, starting with the G5 generation (laguna).
> +  Two specific PHY IPs from Synopsys are integrated, including eUSB 2.0 PHY IP
> +  and USB3.2/DisplayPort combo PHY IP.

...

> > +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        usb_phy: usb_phy@c410000 {

node name: usb-phy, because there are no underscors used anywhere in
upstream. While at it, you can drop the label as well, because it is not
uised, so just usb-phy@..... {

Please send new version with these two fixed and:

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof