Re: [RFC PATCHv5 2/6] zram: add writeback batch size device attr
From: Sergey Senozhatsky
Date: Thu Nov 20 2025 - 21:48:51 EST
On (25/11/21 00:21), Sergey Senozhatsky wrote:
> +static ssize_t writeback_batch_size_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> +{
> + struct zram *zram = dev_to_zram(dev);
> + u32 val;
> + ssize_t ret = -EINVAL;
> +
> + if (kstrtouint(buf, 10, &val))
> + return ret;
> +
> + if (!val)
> + val = 1;
> +
> + down_read(&zram->init_lock);
> + zram->wb_batch_size = val;
> + up_read(&zram->init_lock);
> + ret = len;
> +
> + return ret;
> +}
JFI, as was suggested by Andrew in v4 thread, this should use write
lock.