Re: [PATCHv4 2/6] zram: add writeback batch size device attr

[Sergey Senozhatsky]

On (25/11/20 17:17), Andrew Morton wrote:
> > +static ssize_t writeback_batch_size_store(struct device *dev,
> > +					  struct device_attribute *attr,
> > +					  const char *buf, size_t len)
> > +{
> > +	struct zram *zram = dev_to_zram(dev);
> > +	u32 val;
> > +	ssize_t ret = -EINVAL;
> > +
> > +	if (kstrtouint(buf, 10, &val))
> > +		return ret;
> > +
> > +	if (!val)
> > +		val = 1;
> > +
> > +	down_read(&zram->init_lock);
> 
> down_write()?

Indeed.  Thanks!