Re: [PATCH] mm/vmalloc: fix build error

[John Hubbard]

On 11/18/25 7:50 AM, Peng Li wrote:
> From: Peng Li <peng8420.li@xxxxxxxxx>
> 
> commit 056b93566a35 ("mm/vmalloc: warn only once when vmalloc
> detect invalid gfp flags") modify the function call from WARN to WARN_ONCE.
> 
> WARN_ONCE input parameter format error, missing ',' tag.
> Resulting in the following compilation errors:
> 
> mm/vmalloc.c:3940:19: error: expected ‘)’ before ‘invalid_mask’
>  3940 |                   invalid_mask, &invalid_mask, flags, &flags);
> 
> After adding the "," tag, the compilation passed.
> 
> Signed-off-by: Peng Li <peng8420.li@xxxxxxxxx>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>

thanks,
-- 
John Hubbard

> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index d78c4d09d6ea..0469ba2c230e 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -3936,7 +3936,7 @@ static gfp_t vmalloc_fix_flags(gfp_t flags)
>  	gfp_t invalid_mask = flags & ~GFP_VMALLOC_SUPPORTED;
>  
>  	flags &= GFP_VMALLOC_SUPPORTED;
> -	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n"
> +	WARN_ONCE(1, "Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n",
>  		  invalid_mask, &invalid_mask, flags, &flags);
>  	return flags;
>  }