Re: [PATCH net] vsock: Ignore signal/timeout on connect() if already established

From: Michal Luczaj

Date: Thu Nov 20 2025 - 16:12:43 EST


On 11/19/25 20:52, Michal Luczaj wrote:
> ...
> To follow up, should I add a version of syzkaller's lockdep warning repro
> to vsock test suite? In theory it could test this fix here as well, but in
> practice the race window is small and hitting it (the brute way) takes
> prohibitively long.

Replying to self to add more data.

After reverting

f7c877e75352 ("vsock: fix lock inversion in vsock_assign_transport()")
002541ef650b ("vsock: Ignore signal/timeout on connect() if already
established")

adding

--- a/tools/testing/vsock/vsock_test.c
+++ b/tools/testing/vsock/vsock_test.c
@@ -2014,6 +2014,7 @@ static void test_stream_transport_change_client(const
struct test_opts *opts)
perror("socket");
exit(EXIT_FAILURE);
}
+ enable_so_linger(s, 1);

ret = connect(s, (struct sockaddr *)&sa, sizeof(sa));
/* The connect can fail due to signals coming from the

is enough for vsock_test to trigger the lockdep warning syzkaller found.