Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10)
From: Lukas Timmermann
Date: Thu Nov 20 2025 - 15:27:49 EST
On Thu, Nov 20, 2025 at 06:36:29PM +0100, Krzysztof Kozlowski wrote:
> On 20/11/2025 18:31, Henrik Grimler wrote:
> > Hi Lukas,
> >
> > On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote:
> >> From: Alexandre Marquet <tb@xxxxxxxxxxxx>
> >>
> >> Manta is the code name for Google Nexus 10, and was manufactured by
> >> Samsung. This patch adds initial device-tree file for this board.
> >>
> >> Co-developed-by: Alexandre Marquet <tb@xxxxxxxxxxxx>
> >> Signed-off-by: Alexandre Marquet <tb@xxxxxxxxxxxx>
> >> Co-developed-by: Lukas Timmermann <linux@timmermann.space>
> >> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> >
> > Awesome! I think this series would benefit from a cover letter
> > explaining what features are working, and perhaps saying something
> > about other patches that will be sent separately (if any). The as3668
> > led driver and bindings for example has not been merged, right? Adding
> > the lore link in a cover letter would therefore help reviewers.
>
> If "not merged" in the meaning of not taken by maintainer for next, then
> this is quite important because it not only blocks this patch but would
> cause failures in CI leading me to being grumpy.
>
> Samsung SoC follows maintainer-soc-clean-dts profile. Please always
> explicitly document such stuff (bindings in fly).
>
> Best regards,
> Krzysztof
>
I just noticed, that my cover letter did not get send to the mailing.
That was unintentional. In there, I wrote that this patch depends on an
earlier patch which still needs some work. Should I also add that to the
individual patch in future mails?
I'm still quite new to the mailing list workflow. I'm sorry for any
misunderstandings.
Best regards,
Lukas Timmermann