Re: [PATCH 1/1] scsi: ufs: core: Fix EH failure after wlun resume error

[Bart Van Assche]

On 11/11/25 10:32 PM, Po-Wen Kao wrote:
> When a W-LUN resume fails, its parent devices in the SCSI hierarchy,
> including the scsi_target, may be runtime suspended. Subsequently, the
> error handler in ufshcd_recover_pm_error() fails to set the W-LUN
> device back to active because the parent target is not active.
> This results in the following errors:
>
>    google-ufshcd 3c2d0000.ufs: ufshcd_err_handler started; HBA state eh_fatal; ...
>    ufs_device_wlun 0:0:0:49488: START_STOP failed for power mode: 1, result 40000
>    ufs_device_wlun 0:0:0:49488: ufshcd_wl_runtime_resume failed: -5
>    ...
>    ufs_device_wlun 0:0:0:49488: runtime PM trying to activate child device 0:0:0:49488 but parent (target0:0:0) is not active
>
> This patch addresses this by:
>
> 1.  Ensuring the W-LUN's parent scsi_target is runtime resumed before
> attempting to set the W-LUN to active within ufshcd_recover_pm_error().
> 2.  Explicitly checking for power.runtime_error on the HBA and W-LUN
> devices before calling pm_runtime_set_active() to clear the error state.
> 3.  Adding pm_runtime_get_sync(hba->dev) in
> ufshcd_err_handling_prepare() to ensure the HBA itself
> is active during error recovery, even if a child device resume failed.
>
> These changes ensure the device power states are managed correctly
> during error recovery.

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>