Re: [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs

[Manivannan Sadhasivam]

On Thu, Nov 20, 2025 at 05:04:31PM +0100, Lukas Wunner wrote:
> On Thu, Nov 20, 2025 at 09:16:01PM +0530, Manivannan Sadhasivam wrote:
> > +++ b/drivers/pci/quirks.c
> > @@ -2525,6 +2525,18 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
> >   */
> >  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
> >  
> > +static void quirk_disable_aspm_l1(struct pci_dev *dev)
> > +{
> > +       pci_info(dev, "Disabling ASPM L1\n");
> > +       pci_disable_link_state(dev, PCIE_LINK_STATE_L1);
> > +}
> 
> Shouldn't this be using pcie_aspm_remove_cap()?  Existing quirks
> were converted to this new helper with 30579eebba6a.
> 

Ah, I didn't notice that Bjorn's series got merged into mainline. Will rebase
and send v2.

- Mani

-- 
மணிவண்ணன் சதாசிவம்