Re: [PATCH net-next v5 4/5] netconsole: resume previously deactivated target

[Breno Leitao]

On Wed, Nov 19, 2025 at 07:49:22AM +0000, Andre Carvalho wrote:
> Attempt to resume a previously deactivated target when the associated
> interface comes back (NETDEV_UP event is received) by calling
> __netpoll_setup on the device.
> 
> Depending on how the target was setup (by mac or interface name), the
> corresponding field is compared with the device being brought up.
> 
> Targets that are candidates for resuming are removed from the target list
> and added to a temp list, as __netpoll_setup is IRQ unsafe.
> __netpoll_setup assumes RTNL is held (which is guaranteed to be the
> case when handling the event). In case of success, hold a reference to
> the device which will be removed upon target (or netconsole) removal by
> netpoll_cleanup.
> 
> Target transitions to STATE_DISABLED in case of failures resuming it to
> avoid retrying the same target indefinitely.
> 
> Signed-off-by: Andre Carvalho <asantostc@xxxxxxxxx>

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>

This is now conflicting with Gustavo's patchset. I would suggest we get
Gustavo's patches merged first, and then you respin this one, please.

Thus, I am marking this as "change-requested" just to help the main
network maintainers, if that is the right process.

--
pw-bot: cr