Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor_bits
From: Nikolay Borisov
Date: Thu Nov 20 2025 - 10:45:13 EST
On 11/20/25 17:41, Borislav Petkov wrote:
On Tue, Nov 18, 2025 at 02:36:08PM +0200, Nikolay Borisov wrote:
Fair point, but bitwise xor is the lowest possible operation, I guess we
care about the higher-level effect, which is calculating parity.
... in a function which "Calculate hash for each Bank bit."?
I don't think it matters either way. This is converting the DRAM addressing
scheme into normalized addresses so as long as it is clear what happens
there...
So are you saying the patch should be dropped altogether or that the changelog should be reworded? The way I see it, the parity for the given bank's col/row are calculated and this then is used into calculating the hash.