Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

[Alexandre Belloni]

On 20/11/2025 20:17:59+0800, ot_shunxi.zhang@xxxxxxxxxxxx wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@xxxxxxxxxxxx>
> 
> This is a cosmetic change to improve code consistency.
> 

But, is it?

> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@xxxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-mt6397.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 692c00ff544b..b8f44a00de5d 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -345,7 +345,7 @@ static struct platform_driver mtk_rtc_driver = {
>  		.of_match_table = mt6397_rtc_of_match,
>  		.pm = &mt6397_pm_ops,
>  	},
> -	.probe	= mtk_rtc_probe,

I guess the original author wanted to align with the members of the
.drivers struct above. I won't take a patch to change just that as the
next guys wanting to improve his KPIs will do the exact opposite.


> +	.probe = mtk_rtc_probe,
>  };
>  
>  module_platform_driver(mtk_rtc_driver);
> -- 
> 2.45.2
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com