Re: [PATCH V2] USB: serial: option: add Telit FN920C04 RNDIS compositions

[Johan Hovold]

On Thu, Nov 20, 2025 at 12:39:08PM +0000, LI Qingwu wrote:
> 0x10a1: RNDIS + tty (NMEA) + tty (AT) [+ tty (DIAG)]

> Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
> ---

What changed in v2? Always include a short changelog here after the ---
line when respinning.

>  drivers/usb/serial/option.c | 6 ++++++
>
1 file changed, 6 insertions(+)
> @@ -1415,6 +1419,8 @@ static const struct usb_device_id option_ids[] = {
>  	  .driver_info = RSVD(0) | NCTRL(2) | RSVD(3) | RSVD(4) },
>  	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10aa, 0xff),	/* Telit FN920C04 (MBIM) */
>  	  .driver_info = NCTRL(3) | RSVD(4) | RSVD(5) },
> +	{ USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x10ab, 0xff),	/* Telit FN920C04 (RNDIS) */
> +	  .driver_info = | NCTRL(3) | RSVD(4) | RSVD(5) },

This does not like it will even compile...

>  	{ USB_DEVICE_AND_INTERFACE_INFO(TELIT_VENDOR_ID, 0x10b0, 0xff, 0xff, 0x30),	/* Telit FE990B (rmnet) */
>  	  .driver_info = NCTRL(5) },
>  	{ USB_DEVICE_AND_INTERFACE_INFO(TELIT_VENDOR_ID, 0x10b0, 0xff, 0xff, 0x40) },

Johan