Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

[Konrad Dybcio]

On 11/20/25 11:58 AM, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> Two of these ports are available in mainboard and one port
> is available on Mezz board. lt8713sx is connected to soc over
> i2c0 and with reset gpio connected to pin6 or ioexpander5.
> 
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
> 
> Co-developed-by: Prahlad Valluru <vvalluru@xxxxxxxxxxxxxxxx>
> Signed-off-by: Prahlad Valluru <vvalluru@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vishnu Saini <vishnu.saini@xxxxxxxxxxxxxxxx>
> ---

[...]

> +&i2c0 {
> +	pinctrl-0 = <&qup_i2c0_default>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	lt8713sx: lt8713sx@4f {

Node names should be generic, so bridge@4f

> +		/*Display bridge chip, DP1.4/HDMI2.0/DP++ hub*/

Comment start/stop markers should have a space after/before them
respectively, however I'm not sure this comment is useful given the
dt-bindings already describe what it is

[...]

>  &tlmm {
> +	dp_hot_plug_det: dp-hot-plug-det-state {
> +		pins = "gpio94";
> +		function = "edp0_hot";
> +		bias-disable;

This is an SoC-mandated function on the pin, so please move it to
monaco.dtsi

> +	};
> +
>  	ethernet0_default: ethernet0-default-state {
>  		ethernet0_mdc: ethernet0-mdc-pins {
>  			pins = "gpio5";
> @@ -451,6 +488,13 @@ ethernet0_mdio: ethernet0-mdio-pins {
>  		};
>  	};
>  
> +	qup_i2c0_default: qup-i2c0-state {
> +		pins = "gpio17", "gpio18";
> +		function = "qup0_se0";
> +		drive-strength = <2>;
> +		bias-pull-up;

Similarly, you can move these settings to monaco.dtsi and keep them as
defaults since 99.99% of I2C users will share them

Konrad