Re: [PATCH -next] coresight: remove unneeded semicolon

[James Clark]

On 20/11/2025 9:41 am, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/hwtracing/coresight/coresight-priv.h:238:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=27327
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>   drivers/hwtracing/coresight/coresight-priv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index fd896ac07942..16f0cee8cad6 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -235,7 +235,7 @@ static inline void *coresight_get_uci_data_from_amba(const struct amba_id *table
>   		if ((pid & table->mask) == table->id)
>   			return coresight_get_uci_data(table);
>   		table++;
> -	};
> +	}
>   	return NULL;
>   }
>   

Reviewed-by: James Clark <james.clark@xxxxxxxxxx>

I turned on -Wextra-semi-stmt for Coresight but it results in hundreds 
warnings because of the way macros like wmb() are always used with a 
semicolon.

So I'm not really sure what the point of fixing these up is? Because 
they can never all be fixed without a fundamental style change so why 
not just ignore them?

James