RE: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX deemphasis

[Pandey, Radhey Shyam]

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Thursday, November 20, 2025 1:50 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx>
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>;
> Thinh.Nguyen@xxxxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>
> Subject: Re: [PATCH 3/3] usb: dwc3: xilinx: Add support to program MMI USB TX
> deemphasis
>
> On Thu, Nov 20, 2025 at 01:00:36AM +0530, Radhey Shyam Pandey wrote:
> >  struct dwc3_xlnx {
> >     int                             num_clocks;
> > @@ -306,7 +307,7 @@ MODULE_DEVICE_TABLE(of, dwc3_xlnx_of_match);
> > static int dwc3_set_swnode(struct device *dev)  {
> >     struct device_node *np = dev->of_node, *dwc3_np;
> > -   struct property_entry props[2];
> > +   struct property_entry props[3];
> >     int prop_idx = 0, ret = 0;
> >
> >     dwc3_np = of_get_compatible_child(np, "snps,dwc3"); @@ -320,6
> > +321,10 @@ static int dwc3_set_swnode(struct device *dev)
> >     if (of_dma_is_coherent(dwc3_np))
> >             props[prop_idx++] = PROPERTY_ENTRY_U16("snps,gsbuscfg0-
> reqinfo",
> >                                                    0xffff);
> > +   if (of_device_is_compatible(np, "xlnx,versal2-mmi-dwc3"))
>
> Don't sprinkle compatibles all over the code - it does not scale. You have driver
> match data for that.

Sure, in v2 will use match data flag to specify if TX deemphasis need
to be reprogrammed.

Thanks,
Radhey