Re: [PATCH] PM / devfreq: hisi: Fix potential UAF in OPP handling

[Chanwoo Choi]

Hi,

I'm sorry for late reply.

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

If you need to apply this patch to other git repository with some
related patch, I agree.

Thanks,

On Thu, Nov 20, 2025 at 10:31 AM zhangpengjie (A)
<zhangpengjie2@xxxxxxxxxx> wrote:
>
>
> Hi All,
>
> This is a friendly follow-up on this patch.
>
> Given that everyone is often busy with various tasks, I wanted to make
> sure it doesn't fall through the cracks.
>
> Thank you for your time and review.
>
> Best regards,
> Pengjie Zhang
>
> On 9/15/2025 2:21 PM, Pengjie Zhang wrote:
> > Ensure all required data is acquired before calling dev_pm_opp_put(opp)
> > to maintain correct resource acquisition and release order.
> >
> > Fixes: 7da2fdaaa1e6 ("PM / devfreq: Add HiSilicon uncore frequency scaling driver")
> > Signed-off-by: Pengjie Zhang <zhangpengjie2@xxxxxxxxxx>
> > ---
> >   drivers/devfreq/hisi_uncore_freq.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/hisi_uncore_freq.c b/drivers/devfreq/hisi_uncore_freq.c
> > index 96d1815059e3..c1ed70fa0a40 100644
> > --- a/drivers/devfreq/hisi_uncore_freq.c
> > +++ b/drivers/devfreq/hisi_uncore_freq.c
> > @@ -265,10 +265,11 @@ static int hisi_uncore_target(struct device *dev, unsigned long *freq,
> >               dev_err(dev, "Failed to get opp for freq %lu hz\n", *freq);
> >               return PTR_ERR(opp);
> >       }
> > -     dev_pm_opp_put(opp);
> >
> >       data = (u32)(dev_pm_opp_get_freq(opp) / HZ_PER_MHZ);
> >
> > +     dev_pm_opp_put(opp);
> > +
> >       return hisi_uncore_cmd_send(uncore, HUCF_PCC_CMD_SET_FREQ, &data);
> >   }
> >
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics