Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

[Siddharth Vadapalli]

On 19/11/25 7:57 PM, Vignesh Raghavendra wrote:
> On 19/11/25 14:13, Siddharth Vadapalli wrote:
> > On Wed, 2025-11-19 at 13:38 +0530, Vignesh Raghavendra wrote:
> >
> > Hello Vignesh,
> >
> > > On 18/11/25 17:19, Siddharth Vadapalli wrote:
> > > > Commit under Fixes added support for power regulators on the J721E SK
> > >
> > > ^^^ not the right way to quote a commit. Should follow commit SHA
> >
> > I started following this format after I noticed that an earlier patch of
> > mine at [0]
> > was merged to the Networking Tree with the commit message updated to follow
> > this format [1]. I acknowledge that the expected format might be different
> > across subsystems, but I used this format since it seemed concise to me and
> > I believe that it makes it easier for the reader.
>
> Ok,  seems common in netdev but not outside of that tree.
>
> > However, if the format should be:
> > commit SHA ("$subject")
> > for the TI-K3-DTS Tree as a policy, I will fix the format and post the v2
> > patch.
> >
> > [0]: https://lore.kernel.org/r/20241220075618.228202-1-s-vadapalli@xxxxxx/
> > [1]:
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=4a4d38ace1fb
> >
> > > ("$subject") format. Moreover this paragraph can be simply be stated as
> > > node is under wrong pmx region (wakeup) and instead should be moved to main
> >
> > Please let me know if I should post a v2 for this or if you plan to correct
> > it locally
> > (in case the 'commit SHA ("$subject") format doesn't require a v2).
>
> There really is no need to quote the offending commit as part of the
> text as Fixes Tag makes it obvious. You would just have to describe that
> node is in the wrong parent node and needs to be moved under main pmx
> node with appropriate reference to TRM/Doc

Thank you for the clarification. I will keep the commit message concise 
and post the v2 patch.

Regards,
Siddharth.