Re: [PATCH v8 06/11] dma-buf: provide phys_vec to scatter-gather mapping routine

From: Leon Romanovsky

Date: Wed Nov 19 2025 - 08:30:06 EST


On Wed, Nov 19, 2025 at 05:54:55AM +0000, Tian, Kevin wrote:
> > From: Leon Romanovsky <leon@xxxxxxxxxx>
> > Sent: Tuesday, November 11, 2025 5:58 PM
> > +
> > + if (dma->state && dma_use_iova(dma->state)) {
> > + WARN_ON_ONCE(mapped_len != size);
>
> then "goto err_unmap_dma".

It never should happen, there is no need to provide error unwind to
something that you won't get.

>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

Thanks