Re: [PATCH v1 2/3] VFS: Prepare atomic_open() for dentry_create()

From: Benjamin Coddington

Date: Wed Nov 19 2025 - 08:11:32 EST


On 18 Nov 2025, at 20:32, NeilBrown wrote:

> On Wed, 19 Nov 2025, Benjamin Coddington wrote:
>> The next patch allows dentry_create() to call atomic_open(), but it does
>> not have fabricated nameidata. Let atomic_open() take a path instead.
>
> I think this commit message could usefully be longer and more details.
>
> atomic_open() currently takes a nameidata of which it only uses the
> path and the flags. Flags are only used to update open_flags. That
> update can happen before atomic_open() is called which would mean that
> only the path need be passed to atomic_open() rather than the whole
> nameidata. This will make it easier for dentry_create() To call
> atomic_open().

Thank you! I'll add this.

Ben