Re: [v2, net-next 09/12] bng_en: Add ethtool link settings and capabilities support

[Bhargava Chenna Marreddy]

On Sun, Nov 16, 2025 at 2:38 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > +
> > +     if (!(bd->phy_flags & BNGE_PHY_FL_NO_PAUSE)) {
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Pause_BIT,
> > +                              lk_ksettings->link_modes.supported);
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
> > +                              lk_ksettings->link_modes.supported);
> > +     }
> > +
> > +     if (link_info->support_auto_speeds || link_info->support_auto_speeds2 ||
> > +         link_info->support_pam4_auto_speeds)
> > +             linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> > +                              lk_ksettings->link_modes.supported);
>
> autoneg is more than speed. In fact, 1000BaseX only works are 1G, no
> link speed negotiation, but you can negotiate pause. Do any of the
> link modes you support work like this?

All the speeds we support can be auto-negotiated. We don't see any
cases like 1000Base-X.
Do you see any issue with the above setting autoneg?

>
> > +     /* Note ETHTOOL_LINK_MODE_10baseT_Half_BIT == 0 is a legal Linux
> > +      * link mode, but since no such devices exist
>
> 10BaseT Half devices definitely do exist, and there are actually more
> appearing in the automotive field.

Our devices don't support 10baseT_Half, will fix the comment.

Thanks,
Bhargava Marreddy

>
>
>     Andrew
>
> ---
> pw-bot: cr

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature