Re: [PATCH] arm64: dts: ti: k3-j721e-sk: Fix pinmux for power regulator

[Yemike Abhilash Chandra]

Hi Siddharth,
Thanks for the fix.

On 18/11/25 17:19, Siddharth Vadapalli wrote:
> Commit under Fixes added support for power regulators on the J721E SK
> board. However, while doing so, it incorrectly assigned a non-existent
> pinmux within the WKUP Pinmux region (pinctrl@4301c000) instead of using
> the MAIN Pinmux region (pinctrl@11c000). This leads to the following
> silent failure:
>
>      pinctrl-single 4301c000.pinctrl: mux offset out of range: 0x1dc (0x178)
>
> The datasheet for the J721E SoC [0] specifies on page 142 that the
> pinmux of interest which is Ball Y1 is PADCONFIG119 and the address
> corresponding to it is 0x00011C1DC which belongs to the MAIN Pinmux
> region.
>
> Hence, fix this.
>
> [0]: https://www.ti.com/lit/ds/symlink/tda4vm.pdf
> Fixes: 97b67cc102dc ("arm64: dts: ti: k3-j721e-sk: Add DT nodes for power regulators")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@xxxxxx>

Thanks and Regards
Yemike Abhilash Chandra

> ---
>
> Hello,
>
> This patch is based on commit
> e7c375b18160 Merge tag 'vfs-6.18-rc7.fixes' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
> of Mainline Linux.
>
> Regards,
> Siddharth.
>
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 5e5784ef6f85..77dcc160eda3 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -474,6 +474,12 @@ rpi_header_gpio1_pins_default: rpi-header-gpio1-default-pins {
>   			J721E_IOPAD(0x234, PIN_INPUT, 7) /* (U3) EXT_REFCLK1.GPIO1_12 */
>   		>;
>   	};
> +
> +	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> +		>;
> +	};
>   };
>   
>   &wkup_pmx0 {
> @@ -536,12 +542,6 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
>   		>;
>   	};
>   
> -	vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> -		pinctrl-single,pins = <
> -			J721E_IOPAD(0x1dc, PIN_OUTPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> -		>;
> -	};
> -
>   	wkup_uart0_pins_default: wkup-uart0-default-pins {
>   		pinctrl-single,pins = <
>   			J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */