Re: [RFC net-next] eth: fbnic: use ring->page_pool instead of page->pp in fbnic_clean_twq1()

From: Jakub Kicinski

Date: Tue Nov 18 2025 - 21:48:55 EST


On Wed, 19 Nov 2025 11:45:46 +0900 Byungchul Park wrote:
> > @ring in this context is the Tx ring, but it's the Rx ring that has the
> > page_pool pointer. Each Rx+Tx queue pair has 6 rings in total. You need
> > the sub0/sub1 ring of the Rx queue from which the page came here.
>
> Thank you for the explanation. I'd better make it in the following way
> rather than modifying the unfamiliar code. Looks fine?

Yes, I think that's fine. Just please wrap the long lines at 80 chars
in networking.